test: Change erased type in AnnotationTest #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kohlschuetter
force-pushed
the
ck/RemoveAccessibilityProvider
branch
from
6df5924
to
9c4b013
Compare
Just to test a type erasure, we currently reference javax.accessibility.AccessibilityProvider, which is in the "java.deskop" module. If we were to modularize jsweet, we would have to "requires java.desktop" just for this (or Eclipse would not be able to run unit tests). Moreover, that module may not exist in all JVM environments. Change to a similar class in "java.base", ServiceLoader, and adjust module-info.java.txt accordingly.
kohlschuetter
force-pushed
the
ck/RemoveAccessibilityProvider
branch
from
9c4b013
to
34d9e67
Compare
|
@renaudpawlak This one also needs merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to test a type erasure, we currently reference javax.accessibility.AccessibilityProvider, which is in the "java.deskop" module.
If we were to modularize jsweet, we would have to "requires java.desktop" just for this (or Eclipse would not be able to run unit tests).
Moreover, that module may not exist in all JVM environments.
Change to a similar class in "java.base", ServiceLoader, and adjust module-info.java.txt accordingly.